Handle multiline properties & update css list #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanPurdy
changed the title
DanPurdy
force-pushed
the
feature/update-misspelled-properties
branch
from
ec7e238
to
ecc7d1b
Compare
bgriffith
approved these changes
Aug 26, 2017
| } | ||
| else { | ||
| propList.push({ | ||
| name: currentProperty.name + PROP_DIVIDER + prop.first('ident').content, |
There was a problem hiding this comment.
Could abstract this string generation instead of repeating it.
| name: currentProperty.name + PROP_DIVIDER + prop.first('ident').content, | ||
| line: prop.first().start.line, | ||
| col: prop.first().start.column, | ||
| propsEncountered: propsEncountered |
There was a problem hiding this comment.
Yeah... would be good. We can move up soon.
| } | ||
| // If we have multiline properties | ||
| if (fullProperties.length) { | ||
| fullProperties.forEach(function (constrProp) { |
There was a problem hiding this comment.
constructed property... I think 😄
| // If we have multiline properties | ||
| if (fullProperties.length) { | ||
| fullProperties.forEach(function (constrProp) { | ||
| // Add the number of propertiy declarations we've already checked here so we can skip them |
There was a problem hiding this comment.
Typo - ...number of property...
| }); | ||
| } | ||
| else { | ||
| if (curProperty && curProperty.length > 0) { |
There was a problem hiding this comment.
Could combine the else if and just run with ...curProperty.length)
There was a problem hiding this comment.
curProperty 'could' technically be undefined here. Would rather leave the check just in case as we don't wanna get length of undefined. Can remove the > 0 though as that's unnecessary
There was a problem hiding this comment.
Aye, sorry the > 0 is what I was talking about 👍
DanPurdy
force-pushed
the
feature/update-misspelled-properties
branch
from
ecc7d1b
to
8a7f07e
Compare
DanPurdy
force-pushed
the
feature/update-misspelled-properties
branch
from
8a7f07e
to
d157eb8
Compare
bgriffith
approved these changes
Aug 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues with the
no-misspelled-propertiesrule. It currently doesn't work very well with multiline properties and only does partial string matches without trying to understand the context which in turn means it would let spelling errors through.e.g.
I've also moved away from our own maintained list of properties to a more coherent, full and more importantly maintained list known-css-properties. Any properties that aren't featured there can either be requested to be added there OR added to the extra properties setting of this rule. This will lead to a lot less frustration with our poorly maintained list.
fixes #1101
fixes #1024
fixes #1045
fixes #951
fixes #805
fixes #720
closes #1062
closes #767
I'll update the vendor prefixes rule on top of this too and then we can removed our properties file.
<DCO 1.1 Signed-off-by: Dan Purdy dan@dpurdy.me>