Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backdrop-filter to properties list #767

Closed
wants to merge 1 commit into from
Closed

Add backdrop-filter to properties list #767

wants to merge 1 commit into from

Conversation

controversial
Copy link

What do the changes you have made achieve?
Added backdrop-filter as a known property. This is used fairly widely, most notably on some pages of Apple's website. It's available (with -webkit-) on safari (desktop and mobile), and is available without prefix in recent Chrome Canary builds.

Although it's only widely available with prefix, it still shows as a misspelled property in configs that have vendor prefix warnings disabled.

Are there any new warning messages?
No
Have you written tests?
Nope. If this is the kind of thing that needs tests, let me know, and I'll gladly write one
Have you included relevant documentation
Is documentation relevant for this?
Which issues does this resolve?
No open issues

<DCO 1.1 Signed-off-by: Luke Deen Taylor luke@deentaylor.com>

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.374% when pulling 22e7fef on controversial:patch-1 into a4db3f8 on sasstools:develop.

1 similar comment
@coveralls
Copy link

coveralls commented Jun 28, 2016

Coverage Status

Coverage remained the same at 97.374% when pulling 22e7fef on controversial:patch-1 into a4db3f8 on sasstools:develop.

@DanPurdy
Copy link
Member

@controversial I'm not sure about this, it's currently listed as a non official property and under an editors draft, with usage only possible with a vendor prefix. Can you not just add it to the extra properties option within the rule instead?

https://github.com/sasstools/sass-lint/blob/develop/docs/rules/no-misspelled-properties.md

@sasstools/sass-lint-contributors any opinions?

@controversial
Copy link
Author

controversial commented Jun 30, 2016

Yeah, I guess I could. While it's not the end of the world if this doesn't get merged, what's the argument for not merging it? The way I see it,

  • It's not similar enough to any other properties that it could realistically cause false positives with spelling
  • It's already available in Chrome without prefix, it's just hidden behind a flag, which seems to indicate that it's on the path to being supported.
  • It's been used in production by Apple and a few others for more than a year.

So... why not merge it? It seems to me like there are only advantages, no disadvantages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants