Fix CLI custom config assertion error #150 #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also I've just realised for 1.2.1 we should probably roll this directly into master too, I can open another PR for that if you're happy with this or if there's another way you'd like to handle this. |
This was referenced Sep 10, 2015
Closed
Snugug
added a commit
that referenced
this pull request
Sep 11, 2015
Fix CLI custom config assertion error #150
|
Going to have to cherry pick the commits off of this branch to merge them into master for 1.2.1 |
donabrams
pushed a commit
to donabrams/sass-lint
that referenced
this pull request
Nov 19, 2015
Fix CLI custom config assertion error sasstools#150
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an assertion error you would encounter if using the CLI from a directory that didn't contain a
.sass-lint.ymlorpackage.jsonwith a config file specified.The reason being the format and output functions of the linter weren't being passed the config options from the CLI and therefore were defaulting to whatever config was in the current directory. If these don't exist then we encounter assertion errors.
Also added 3 tests for the CLI custom config path
closes #150
DCO 1.1 Signed-off-by: Dan Purdy danjpurdy@gmail.com