Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/reset defaults on new assertion color literals #187

Conversation

bgriffith
Copy link
Member

Fixes an issue where any modification to the colorFunctions array when testing using assertions gets carried across to the next. The issue is fixed by always creating a copy of initial array and then modifying that instead when each time an assertion is run.

Closes #186

DCO 1.1 Signed-off-by: Ben Griffith gt11687@gmail.com

@bgriffith bgriffith added this to the 1.3.0 milestone Sep 19, 2015
@bgriffith bgriffith mentioned this pull request Sep 21, 2015
41 tasks
@DanPurdy
Copy link
Member

Should avoid a few testing problems 👍

Update and I'll merge

DanPurdy added a commit that referenced this pull request Sep 22, 2015
…assertion-color-literals

Feature/reset defaults on new assertion color literals
@DanPurdy DanPurdy merged commit 0965d28 into sasstools:develop Sep 22, 2015
@bgriffith bgriffith deleted the feature/reset-defaults-on-new-assertion-color-literals branch September 24, 2015 22:25
donabrams pushed a commit to donabrams/sass-lint that referenced this pull request Nov 19, 2015
…s-on-new-assertion-color-literals

Feature/reset defaults on new assertion color literals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no-color-literals rule mutating a value - effecting assertions that follow
2 participants