-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update property sort order #331
Update property sort order #331
Conversation
I should also add some extra text to the documentation here. |
This looks great 👍 |
Going to also add a flag to this to disable this behaviour if needs be. Some might want their 'custom' properties to be ordered. |
8b51527
to
7850b00
Compare
Torn on whether default value for On one hand I feel that custom values could be miss-spelt properties and therefore should not be ignored. On the other a default action of ignoring anything custom would offer ease of use without either side having to take further actions to get this rule working for them. Thoughts? |
I think it should remain as false. The default sort order is alphabetical and so it would provide a consistent approach straight out of the box where as it takes a little extra configuration and reading of the documentation to understand why you may not want that and to understand why your custom or misspelt property isn't being linted. |
Fair point. Let's stick with false. |
Updates the
property-sort-order
rule to ignore non standard CSS properties to allow custom properties as described in #302Closes #302
Looking for possible feedback on this to see if we think this check should be enabled or disabled by an option flag or whether a whitelist would be preferable to this check.
DCO 1.1 Signed-off-by: Dan Purdy danjpurdy@gmail.com