Delete get_nz_median, fix usage in get_residuals_var, add unit tests #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch deletes some leftover artifacts from get_nz_median (such as the documentation), fixes the usage of get_nz_median2 in get_residual_var since it also needs to support subsetting genes, and adds two unit tests to ensure that get_nz_median2 is functioning correctly. Co-authored-by: Todd Pocuca <toddpocu@gmail.com>
|
Thanks very musch @boomanaiden154 and @ScreachingFire! This looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch deletes some leftover artifacts from
get_nz_median(such as the documentation), fixes the usage ofget_nz_median2inget_residual_varsince it also needs to support subsetting genes, and adds two unit tests to ensure thatget_nz_median2is functioning correctly.This should keep the fast performance of the implementation for
get_nz_median2while also allowing gene subsetting.Co-authored-by: @ScreachingFire