Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update liger-related functions and vignette #41

Merged
merged 7 commits into from
Jun 3, 2020
Merged

Update liger-related functions and vignette #41

merged 7 commits into from
Jun 3, 2020

Conversation

skpalan
Copy link
Contributor

@skpalan skpalan commented May 26, 2020

Dear Seurat Team,

I am Jialin from Dr. Joshua Welch's Lab, University of Michigan. Many thanks for distributing this great package to give users seamlessly experience integrating seurat and liger at the same time.

We recently released another major liger distribution v0.5.0 in which we add some new features and deprecate old functions. In this PR, I made the following modifications to fit this newest version:

  • Add function RunQuantileNorm to replace RunQuantileAlignSNF and RunSNF;
  • Update liger vignette (you can preview it by this link);

Please provide your precious feedback. We will be very excited to see the smoothly integration of seurat and the new version of liger!

@andrewwbutler
Copy link
Collaborator

Hi Jialin,

Thanks for updating! The only changes I've made here were rerunning the vignette in the latest seurat-wrappers docker container and a few stylistic changes (e.g. F to FALSE). Will go ahead and merge if it all looks good to you.

@skpalan
Copy link
Contributor Author

skpalan commented Jun 3, 2020

Hi Andrew,

Yes, I think these changes look good to me. Please go ahead and merge. Many thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants