Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix giscus blog post #392

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Fix giscus blog post #392

merged 1 commit into from
Oct 2, 2024

Conversation

eerison
Copy link
Contributor

@eerison eerison commented Sep 25, 2024

  • Fixed giscus blog post
  • Change the docker-compose.yaml to latest node version (20)

- Fixed giscus blog post
- change the docker-compose.yaml to latest node version (20)
@eerison
Copy link
Contributor Author

eerison commented Sep 25, 2024

Hello @FjellOverflow

thank you for this amazing integration, Could you take a look in this PR please

unfortunately I couldn't make this work without pass a value on client:value="react"

more info: https://docs.astro.build/en/reference/errors/no-client-only-hint/

@FjellOverflow
Copy link
Contributor

Thanks @eerison!
Yeah, your changes and docs reference checks out, I guess I overlooked it 😄 , good job!
For anyone wondering why it might've still worked without (myself included), on build, Astro gives the helpful warning

The client:only directive for Comments is not recognized.
The renderer @astrojs/react will be used. If you intended to use a different renderer, please provide a valid client:only directive.

Guess I also overlooked that 😄

@eerison
Copy link
Contributor Author

eerison commented Sep 25, 2024

then I guess we could merge it @satnaing

:)

@satnaing
Copy link
Owner

satnaing commented Oct 2, 2024

LGTM too.
Thanks for your contribution 🎉

@satnaing satnaing merged commit c11b2a2 into satnaing:main Oct 2, 2024
1 check passed
@eerison eerison deleted the fix-giscus branch October 2, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants