Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Time() and Nanos() methods #50

Closed
wants to merge 1 commit into from
Closed

Conversation

rkuris
Copy link

@rkuris rkuris commented May 21, 2017

These methods can be used to extract time values
from V1 UUIDs

@coveralls
Copy link

coveralls commented May 21, 2017

Coverage Status

Coverage decreased (-1.6%) to 94.946% when pulling 552d1c4 on rkuris:master into 5bf94b6 on satori:master.

@coveralls
Copy link

coveralls commented May 21, 2017

Coverage Status

Coverage increased (+0.2%) to 96.751% when pulling a129dcc on rkuris:master into 5bf94b6 on satori:master.

This was referenced May 21, 2017
@rkuris
Copy link
Author

rkuris commented May 30, 2017

@satori will you please consider this pull request, or let me know what needs to change to accept it?

@jbsturgeon
Copy link

jbsturgeon commented Oct 9, 2017

This is a great addition -- We are trying to move away from gocql and this library is the best alternative minus this one missing function.

@rkuris
Copy link
Author

rkuris commented Oct 9, 2017

@jbsturgeon as this has been oustanding since may, some of us have switched to using a public fork which includes the rollups and the time V1 functions. Please feel free to use the fork at https://github.com/rkuris/go.uuid which also contains a released version 1.2.0 that includes this fix: https://github.com/rkuris/go.uuid/releases/tag/v1.2.0

These methods can be used to extract time values
from V1 UUIDs
@coveralls
Copy link

coveralls commented Jan 3, 2018

Coverage Status

Coverage increased (+0.2%) to 95.847% when pulling 009bb7c on rkuris:master into 0633591 on satori:master.

@rkuris
Copy link
Author

rkuris commented Jun 28, 2018

I've rebased this before, and would be happy to rebase it again if that means it will get accepted.

@michaelrios
Copy link

Would love to see this get added :)
Thanks for doing this!

@rkuris
Copy link
Author

rkuris commented Aug 18, 2018

A bug in the code for this PR has been fixed in gofrs/uuid#31
Strongly recommend moving there, as this repo is not actively maintained.

@rkuris rkuris closed this Aug 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants