-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor UnmarshalText in order to parse hash-like UUID. #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is wondered that simple heuristics improves perfomance significantly. NOW
|
1 similar comment
@satori Your resolution needed! |
satori
added a commit
that referenced
this pull request
Jan 2, 2018
Refactor UnmarshalText in order to parse hash-like UUID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactor
UnmarshalText
in order to support yet another text representation of UUID lilke6ba7b8109dad11d180b400c04fd430c8
. The reason is that this format is quite frequent.I tried to introduce BNF of what
UmarshalText
actually does. In fact it simplifies implementation and future support. On other hand current implementation led to performance degradation(see below before/after).BEFORE
AFTER
Eventually correct
UnmarshalText
should be based on FSA to avoid overhead during parsing.