Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cosmos Ecosystem chains to SLIP 173 #1148

Merged
merged 4 commits into from
Aug 18, 2021
Merged

Conversation

sunnya97
Copy link
Contributor

@sunnya97 sunnya97 commented Aug 18, 2021

Hi, I'm one of the core devs of the Cosmos ecosystem. We actually use bech32 addresses as the default for all the chains in our ecosystem. I just realized that only very few of the chains in Cosmos have registered themselves in the SLIP-173 repo, so I've gathered the HRP info of as many of them I could find, and added them.

The one deleted line is for "IOV", which is a stale entry because they have rebranded to Starname (which I included). See: https://medium.com/iov-internet-of-values/iov-has-become-starname-a95e27165928

@sunnya97
Copy link
Contributor Author

sunnya97 commented Aug 18, 2021

Btw, there's one Cosmos chain (Likecoin) that apparently did not change their HRP prefix from the Cosmos SDK default of cosmos, and thus its addition would break the current 1:1 mapping of chain to prefix. Is this desirable?

@prusnak prusnak merged commit 45a29b5 into satoshilabs:master Aug 18, 2021
@prusnak
Copy link
Member

prusnak commented Aug 18, 2021

Is this desirable?

No. We will not add colliding entries to the list.

@sunnya97
Copy link
Contributor Author

@prusnak Oh in that case we need to remove Likecoin (which was included in this PR)

@prusnak
Copy link
Member

prusnak commented Aug 18, 2021

@prusnak Oh in that case we need to remove Likecoin (which was included in this PR)

Fixed in dac71b5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants