Add a comment for Qtum #554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the previous discussion is here #196, since we cannot change the number 88 in our code, and 2301 is also used by some wallets, we want to leave a comment here.
|
Official number is defined here and thus 2301 is the official number. Using a unonfficial number 88 in the official wallet is bad and you should change it to the official value. |
gutenye
added a commit
to gutenye/slips
that referenced
this pull request
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the previous discussion is here #196,
since we cannot change the number 88 in our code, and 2301 is also used by some wallets, leaving a comment here is better.