Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting memo-type with info of known accounts not working #1210

Open
ebma opened this issue Feb 3, 2021 · 0 comments · May be fixed by #1211
Open

Setting memo-type with info of known accounts not working #1210

ebma opened this issue Feb 3, 2021 · 0 comments · May be fixed by #1211
Labels
bug Something isn't working

Comments

@ebma
Copy link
Member

ebma commented Feb 3, 2021

Stellar-expert introduced a default limit of 10 and a max limit of 200 for their accounts directory request (see here). We'd now need to paginate to fetch all known accounts.
But they also changed the available 'tags'. Now there is only a 'memo-required' tag instead of something like accepts":{"memo":"MEMO_ID"}} so we have to adjust the logic for memos when creating a payment.

@ebma ebma added the bug Something isn't working label Feb 3, 2021
@ebma ebma linked a pull request Feb 8, 2021 that will close this issue
4 tasks
@ebma ebma linked a pull request Feb 15, 2021 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant