build: Publish GitHub tag in release script #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianluong
force-pushed
the
publish_github_tag
branch
2 times, most recently
from
2e7911d
to
50fb270
Compare
dianwen
approved these changes
Aug 30, 2022
|
Looks great! Mind updating the release docs? |
brianluong
force-pushed
the
publish_github_tag
branch
from
50fb270
to
67af139
Compare
brianluong
commented
Aug 30, 2022
| @@ -91,6 +96,14 @@ make VERSION=$RELEASE_VERSION GIT_COMMIT_HASH=$COMMIT_HASH build-archives | |||
| LogStep "Building and pushing the image." | |||
| make GIT_COMMIT_HASH=$COMMIT_HASH DOCKER_HUB_REPO=$DOCKER_HUB_REPO VERSION=$RELEASE_VERSION build-and-push-image | |||
|
|
|||
| if IsProductionRelease | |||
There was a problem hiding this comment.
Added this flag to push tag only on production release
I updated this doc here, but the update was very small: #51 (comment) "After the release script finishes, create a GitHub release for the commit with the version as the tag (following the format v0.1.0). This tag was just pushed by the release script. Upload the archives created by the release script and write release notes." Bold = new stuff |
dianwen
approved these changes
Aug 30, 2022
| @@ -58,9 +63,9 @@ fi | |||
| # exit 1 | |||
| # fi | |||
|
|
|||
| if [ "$DOCKER_HUB_REPO" == "$PRODUCTION_DOCKER_HUB_REPO" ] | |||
| if IsProductionRelease | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed in launch last Friday
Type of change
How Has This Been Tested?
Also
Commented parts of the script out to test IsProductionRelease