feat: route to nodes even if slightly behind max height #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dianwen
reviewed
Sep 27, 2022
internal/route/node_filter.go
Outdated
| @@ -6,6 +6,10 @@ import ( | |||
| "github.com/satsuma-data/node-gateway/internal/metadata" | |||
| ) | |||
|
|
|||
| const ( | |||
| MaxAllowedBlocksBehindHead = 10 | |||
There was a problem hiding this comment.
If we want to guarantee clients will have access to data no staler than some amount of time, we probably want this configurable because of how different the block production times are. The plan is to run one gateway per chain right now, so having this configurable globally would be ok.
There was a problem hiding this comment.
Done - added a new Routing session of the config so that I can pass that into the filter factory and have it be responsible for that part of the config (e.g. handling defaults).
IvanVergiliev
force-pushed
the
stay-near-head
branch
from
dcbd3b7
to
cf1b56a
Compare
brianluong
approved these changes
Sep 28, 2022
IvanVergiliev
force-pushed
the
stay-near-head
branch
from
cf1b56a
to
706260f
Compare
IvanVergiliev
force-pushed
the
stay-near-head
branch
from
706260f
to
4b3c1ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to be able to tolerate some lag in certain situations. For example, we might want to favour our own node over a node provider even if we're slightly behind head. This PR keeps routing to nodes as long as they are within 10 blocks of the max height.
Type of change
How Has This Been Tested?
Added unit tests for new filter.