feat: add debug logging when NodeFilters fail #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
High-level notes:
IsHealthy
filter is broken down into separate Peers and Syncing filters. When implemented in a single function, it was unnecessarily complicated to properly handle all the failure cases and add logging accordingly. Breaking it down makes each filter fairly simple on its own, and it's also easy to combine them because we can reuse theAndFilter
🙂*Check
internals. For example, theHasEnoughPeers
filter needs to access theerr
field of thePeerCheck
object. This seems tolerable for now, but I'm totally open to changing it.IsPassing
methods of the variousChecker
s are gradually becoming redundant. As I move the corresponding logic toNodeFilter
s, I don't think any production code uses theIsPassing
methods anymore. I didn't remove them here because it would've required moving some more code around to get the tests to work and I didn't want to make the PR too huge.Type of change
How Has This Been Tested?
Deployed to staging and made sure I see the logging messages I expect for various <request, upstream> combinations.