Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: option to skip peer count checks on an upstream #96

Merged
merged 1 commit into from
Jan 31, 2023
Merged

feat: option to skip peer count checks on an upstream #96

merged 1 commit into from
Jan 31, 2023

Conversation

dianwen
Copy link
Member

@dianwen dianwen commented Jan 31, 2023

Description

Optimism returns peer count of 0, so we need to skip the check to use Optimism nodes in the gateway.

Type of change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 😎 New feature (non-breaking change which adds functionality)
  • ⁉️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ⚒️ Refactor (no functional changes)
  • 📖 Documentation (updating or adding docs)

How Has This Been Tested?

Tested locally that we can route requests to optimism nodes with skipPeerCountCheck: true.

@dianwen dianwen merged commit de5533b into main Jan 31, 2023
@dianwen dianwen deleted the skip-peercount-check branch January 31, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianluong brianluong brianluong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dianwen @brianluong