-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use progress bar to display docker output #913
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
baa5d8c
feat: Use progress bar to display docker output
tianfeng92 d02744b
make linter happy
tianfeng92 5c73e44
construct docker own progress bar
tianfeng92 9f410eb
wrap bar functions
tianfeng92 badfb5b
use another spinner
tianfeng92 a63f752
cleanup
tianfeng92 15215d4
use spinner and bar both
tianfeng92 2750c0e
update condition
tianfeng92 ac21a7b
refine comment
tianfeng92 4eab55a
update the condition
tianfeng92 24b900b
revert bar to nil
tianfeng92 30e76ed
add comment
tianfeng92 0e77720
identify each by id instead of status
tianfeng92 fe2bc15
revise comment
tianfeng92 659ccaf
revise comment
tianfeng92 edab6b5
Speed estimation is incorrect when in parallel.
tianfeng92 28d82c3
group output by ID
tianfeng92 fd0efd1
Update internal/cmd/docker/push.go
tianfeng92 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does that really break the progress bar?
This works fine for me, even when the loop goes beyond the max total of the bar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not using
Add
.Set64
can break it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/schollz/progressbar/blob/v3.14.3/progressbar.go#L551C1-L557C3
The added number is not checked. So current number is greater than total after this piece of code.
Add
can also break it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄 100% break