Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo functionality #12

Closed
multimeric opened this issue Jan 5, 2017 · 2 comments
Closed

Undo functionality #12

multimeric opened this issue Jan 5, 2017 · 2 comments

Comments

@multimeric
Copy link

I think adding undo/redo functionality is pretty important, as without it you have to restart the whole editor to undo your changes. Luckily it shouldn't be too difficult since most actions can be described as either a cell edit, or a row/column add or delete

@saulpw
Copy link
Owner

saulpw commented Jan 7, 2017

What I'm planning for this, is to have an editlog that tracks all edits and transforms in such a way that they can be replayed on top of the source sheet (the same one or a similarly structured one with different data). Then you could jump to the editlog sheet (M for modifications, or T for transformations? E is currently 'errorlog' but maybe that should move to ^E) and:

  • change or delete any edits manually
  • push a new sheet with current/selected/all edits applied to the same or different source sheet
  • ^Save the editlog for later reuse.
  • ^Reload on the source sheet re-applies the editlog

So undo would be a simple command:

command('u', 'editlog.rows.pop(); reload()', 'undo last edit')

or Mgjdq^R

if done manually.

This would also allow for a tight test framework, with source + editlog + golden output being a complete functional test.

A possible problem is that undo might take a long time with a lot of edits or a large dataset. But I feel like that should be dealt with in a different way.

What do you think about this approach?

@saulpw
Copy link
Owner

saulpw commented Jun 6, 2017

Implemented as of v0.59.

@saulpw saulpw closed this as completed Jun 6, 2017
saulpw pushed a commit that referenced this issue Mar 10, 2023
* [bigquery] fix connect definition

* [bigquery] register in multiple places

* [bigquery] fix circular import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants