Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdsql 'ibis' NameError #2248

Closed
fleimgruber opened this issue Jan 11, 2024 · 4 comments
Closed

vdsql 'ibis' NameError #2248

fleimgruber opened this issue Jan 11, 2024 · 4 comments
Milestone

Comments

@fleimgruber
Copy link

fleimgruber commented Jan 11, 2024

Small description
vdsql can't resolve ibis.

Expected result
vdsql is able to open a .ddb file.

Actual result with screenshot

saul.pw/VisiData v3.0.1
opening C:\Users\LeimgruberF\tmp\data.ddb as vdsql
Traceback (most recent call last):
  File "C:\Users\LeimgruberF\.pyenv\pyenv-win\versions\3.10.11\lib\runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Users\LeimgruberF\.pyenv\pyenv-win\versions\3.10.11\lib\runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "C:\Users\LeimgruberF\lg\.venv\Scripts\visidata.exe\__main__.py", line 7, in <module>
  File "C:\Users\LeimgruberF\lg\.venv\lib\site-packages\visidata\main.py", line 377, in vd_cli
    rc = main_vd()
  File "C:\Users\LeimgruberF\lg\.venv\lib\site-packages\visidata\main.py", line 299, in main_vd
    vs = vd.openSource(p, create=True, **opts) or vd.fail(f'could not open {p}')
  File "C:\Users\LeimgruberF\lg\.venv\lib\site-packages\visidata\_open.py", line 159, in openSource
    vs = vd.openPath(Path(p), filetype=filetype, create=create)  # convert to Path and recurse
  File "C:\Users\LeimgruberF\lg\.venv\lib\site-packages\visidata\_open.py", line 139, in openPath
    return openfunc(p)
  File "C:\Users\LeimgruberF\lg\.venv\lib\site-packages\visidata\apps\vdsql\_ibis.py", line 68, in open_vdsql
    setattr(ibis, p.ext, ext_aliases.get(p.ext))
NameError: name 'ibis' is not defined

Steps to reproduce with sample data and a .vd
Followed instructions from: https://github.com/saulpw/visidata/tree/develop/visidata/apps/vdsql#install-latest-release

Used Poetry instead of plain pip (poetry itself uses pip):

pyproject.toml:

[tool.poetry.dependencies]
...
vdsql = { path = "../dev/visidata/visidata/apps/vdsql", develop = false }

visidata -f vdsql C:\Users\LeimgruberF\tmp\data.ddb

Additional context
Python 3.10.11
VisiData 3.0.1

saulpw added a commit that referenced this issue Jan 13, 2024
@anjakefala anjakefala added this to the 3.0.1 milestone Jan 13, 2024
@anjakefala
Copy link
Collaborator

@fleimgruber This should be fixed on develop!

anjakefala pushed a commit that referenced this issue Jan 15, 2024
anjakefala pushed a commit that referenced this issue Jan 15, 2024
@fleimgruber
Copy link
Author

fleimgruber commented Jan 15, 2024

@anjakefala thanks for letting me know! I am seeing this now with "duckdb" extra installed with ibis-framework, let me know if I should open another issue for that:

image

@anjakefala
Copy link
Collaborator

Yes, please open a seperate issue!

@fleimgruber
Copy link
Author

Separate issue: #2259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants