v2.10.1 #1525
Merged
v2.10.1 #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original currency conversion API data.fixer.io redirects already to apilayer.com and I couldn't find a way to create API keys for the former data.fixer.io API, so I updated the url and passing of parameters. Especially the api key is passed now as header instead as a url param what's certainly reasonable for security. apilayer blocks urllib requests as bot requests (for at least for the free account). apilayers blocks urllib requests even with different user-agents. So, the solution is to add more headers like described in https://stackoverflow.com/questions/13303449/urllib2-httperror-http-error-403-forbidden
(i don't know what I am doing, just following the instruction)
Potentially tests/ will not exist in a context, better to save in current folder. Closes #1499
IMHO a guarding of a sheet should be reverseable, so added this simple command. Not sure if we should show a status, when guarded it's obviously we show, but I decided against showing a status, as unguarded is the normal behaviour and see no reason to differentiate in the status between never guarded or once guarded and then unguarded.
There was a File > Guard menu item so far.
Didn't want to add a 2nd File > Unguard item for a probably very seldom
used functionality.
So changed it to an on/off selection as
File > Guard > on
off
what I think is still convenient and very self explainary.
Now you can do:
@VisiData.before
def run(vd, *args, **kwargs):
ABC()
to execute ABC() before the rest of vd.run(). Similarly @after will run
after (but return the value from the original function).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.