[cmdlog-] log a keystroke if cmd had keyless cause #2304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we fix this with a simpler solution, by returning an empty string for shortcut instead of None? I'm hesitant to add another mapping like this, since it's not generally accurate, and I think it would be confusing to run a command from the guide and see a keystroke on the status bar that you didn't press. Alternatively we could make a function that gets the keystroke for a command, like the HelpSheet |
|
Okay, I'll close this and submit the simpler solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2293. It shuts off the status errors in all the situations I'm aware of.
It doesn't close the issue because there might be a few more ways for the trouble to show up. But I'm pushing this out now to let people run v3.1dev without the errors.