Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: patient segmentation #369

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

KathurimaKimathi
Copy link
Contributor

Review Checklist

Bugs
Features
Tests

Summary*

  • fix: Bug fix for Add the items tackled here as checklists
  • feat: Completed task
  • chore: Incomplete task
    • test: Sub-task 1

Structure*

  • The Pull Request has a proper title that conforms to our MR title standards
  • The Pull Request has one commit, and if there are more than one, they should be squashed
  • The commit should have a proper title and a short description
  • The commit must be signed off
  • Unused imports are not present
  • Dead code is not present
  • Ensure dry running library to confirm changes

Tests

  • Proper and high quality unit, integration and acceptance(if applicable) tests have been written
  • The coverage threshold should not be lowered

Sign off*

  • All comments have been resolved by the reviewers
  • Approved by Czar {replace_with_czar_name}
  • Signed off by second reviewer {replace_with_name}
  • Ensure all checks are done before merging ⚠️
  • All PRs needs to be signed before merging ⚠️

N/B:

  • Add a checklist if more than one item is done.
  • Add screenshots and/or images where necessary
  • Indicate any breakages caused in the UI ❗
  • Where necessary, indicate which issue the Pull Request solves (Closes #)
  • Any new files are updated in the folder structure in the README

@KathurimaKimathi KathurimaKimathi force-pushed the update-patient-segmentaion-data branch 2 times, most recently from 260671e to f8dda04 Compare February 20, 2024 12:59
@KathurimaKimathi KathurimaKimathi marked this pull request as ready for review February 20, 2024 13:30
@KathurimaKimathi KathurimaKimathi force-pushed the update-patient-segmentaion-data branch 4 times, most recently from 1447f3c to 9c44f52 Compare February 21, 2024 08:36
@coveralls
Copy link

coveralls commented Feb 21, 2024

Pull Request Test Coverage Report for Build 7986643901

Details

  • -35 of 122 (71.31%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 81.97%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/clinical/infrastructure/services/pubsub/publisher.go 0 3 0.0%
pkg/clinical/usecases/clinical/questionnaire_response.go 14 18 77.78%
pkg/clinical/infrastructure/services/advantage/service.go 29 36 80.56%
pkg/clinical/presentation/rest/handlers.go 20 27 74.07%
pkg/clinical/presentation/config.go 1 15 6.67%
Totals Coverage Status
Change from base Build 7972982391: -0.05%
Covered Lines: 6833
Relevant Lines: 8336

💛 - Coveralls

Signed-off-by: Kathurima Kimathi <kathurimakimathi415@gmail.com>
@EspiraMarvin EspiraMarvin merged commit 48d7cbf into develop-v2 Feb 21, 2024
6 checks passed
@EspiraMarvin EspiraMarvin deleted the update-patient-segmentaion-data branch February 21, 2024 09:32
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants