Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate referral report pdf #396

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

Salaton
Copy link
Contributor

@Salaton Salaton commented Mar 26, 2024

Review Checklist

Bugs
Features
Tests

Summary*

  • fix: Bug fix for Add the items tackled here as checklists
  • feat: Completed task
  • chore: Incomplete task
    • test: Sub-task 1

Structure*

  • The Pull Request has a proper title that conforms to our MR title standards
  • The Pull Request has one commit, and if there are more than one, they should be squashed
  • The commit should have a proper title and a short description
  • The commit must be signed off
  • Unused imports are not present
  • Dead code is not present
  • Ensure dry running library to confirm changes

Tests

  • Proper and high quality unit, integration and acceptance(if applicable) tests have been written
  • The coverage threshold should not be lowered

Sign off*

  • All comments have been resolved by the reviewers
  • Approved by Czar {replace_with_czar_name}
  • Signed off by second reviewer {replace_with_name}
  • Ensure all checks are done before merging ⚠️
  • All PRs needs to be signed before merging ⚠️

N/B:

  • Add a checklist if more than one item is done.
  • Add screenshots and/or images where necessary
  • Indicate any breakages caused in the UI ❗
  • Where necessary, indicate which issue the Pull Request solves (Closes #)
  • Any new files are updated in the folder structure in the README

@Salaton Salaton marked this pull request as draft March 26, 2024 05:59
@coveralls
Copy link

coveralls commented Mar 26, 2024

Pull Request Test Coverage Report for Build 8433387479

Details

  • 69 of 119 (57.98%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 81.889%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/clinical/infrastructure/datastore/cloudhealthcare/fhir.go 0 12 0.0%
pkg/clinical/presentation/rest/handlers.go 0 13 0.0%
pkg/clinical/usecases/clinical/referral_report.go 64 89 71.91%
Totals Coverage Status
Change from base Build 8421399538: -0.3%
Covered Lines: 7180
Relevant Lines: 8768

💛 - Coveralls

@Salaton Salaton force-pushed the generate-referral-report-pdf branch 2 times, most recently from 2d3d047 to 24133ad Compare March 26, 2024 07:47
@Salaton Salaton marked this pull request as ready for review March 26, 2024 08:47
@Salaton Salaton force-pushed the generate-referral-report-pdf branch from 24133ad to a1582cd Compare March 26, 2024 08:48
@Salaton Salaton force-pushed the generate-referral-report-pdf branch from a1582cd to 2cc02c0 Compare March 26, 2024 09:05
@Muchogoc Muchogoc merged commit defeb7f into develop-v2 Mar 26, 2024
6 checks passed
@Muchogoc Muchogoc deleted the generate-referral-report-pdf branch March 26, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants