Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add distance field to facility response #30

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

Salaton
Copy link
Contributor

@Salaton Salaton commented Nov 1, 2023

This will return the proximity distance to a facility whenever coordinates are provided. The facilities will also be ordered by the distance from the user

Review Checklist

Bugs
Features
Tests

Summary*

  • fix: Bug fix for Add the items tackled here as checklists
  • feat: Completed task
  • chore: Incomplete task
    • test: Sub-task 1

Structure*

  • The Pull Request has a proper title that conforms to our MR title standards
  • The Pull Request has one commit, and if there are more than one, they should be squashed
  • The commit should have a proper title and a short description
  • The commit must be signed off
  • Unused imports are not present
  • Dead code is not present
  • Ensure dry running library to confirm changes

Tests

  • Proper and high quality unit, integration and acceptance(if applicable) tests have been written
  • The coverage threshold should not be lowered

Sign off*

  • All comments have been resolved by the reviewers
  • Approved by Czar {replace_with_czar_name}
  • Signed off by second reviewer {replace_with_name}
  • Ensure all checks are done before merging ⚠️
  • All PRs needs to be signed before merging ⚠️

N/B:

  • Add a checklist if more than one item is done.
  • Add screenshots and/or images where necessary
  • Indicate any breakages caused in the UI ❗
  • Where necessary, indicate which issue the Pull Request solves (Closes #)
  • Any new files are updated in the folder structure in the README

This will return the proximity distance to a facility whenever coordinates are
provided. The facilities will also be ordered by the distance from the user
Copy link

github-actions bot commented Nov 1, 2023

Pull Request Test Coverage Report for Build 6720808589

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.639%

Totals Coverage Status
Change from base Build 6718181698: 0.0%
Covered Lines: 249
Relevant Lines: 305

💛 - Coveralls

@Muchogoc Muchogoc merged commit 217d2ec into main Nov 2, 2023
2 checks passed
@robinmuhia robinmuhia deleted the add-distance branch June 19, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants