Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CPL-312): fixt profile syncing input and output #36

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

BiKodes
Copy link
Contributor

@BiKodes BiKodes commented Apr 17, 2024

Review Checklist

Bugs
Features
Tests

Summary*

  • fix: Bug fix for Add the items tackled here as checklists
  • feat: Completed task
  • chore: Incomplete task
    • test: Sub-task 1

Structure*

  • The Pull Request has a proper title that conforms to our MR title standards
  • The Pull Request has one commit, and if there are more than one, they should be squashed
  • The commit should have a proper title and a short description
  • The commit must be signed off
  • Unused imports are not present
  • Dead code is not present
  • Ensure dry running library to confirm changes

Tests

  • Proper and high quality unit, integration and acceptance(if applicable) tests have been written
  • The coverage threshold should not be lowered

Sign off*

  • All comments have been resolved by the reviewers
  • Approved by Czar {replace_with_czar_name}
  • Signed off by second reviewer {replace_with_name}
  • Ensure all checks are done before merging ⚠️
  • All PRs needs to be signed before merging ⚠️

N/B:

  • Add a checklist if more than one item is done.
  • Add screenshots and/or images where necessary
  • Indicate any breakages caused in the UI ❗
  • Where necessary, indicate which issue the Pull Request solves (Closes #)
  • Any new files are updated in the folder structure in the README

@BiKodes BiKodes force-pushed the fix-profile-sync-data-members branch from 53014b7 to 7f5790d Compare April 17, 2024 09:14
@coveralls
Copy link

coveralls commented Apr 17, 2024

Pull Request Test Coverage Report for Build 8733610733

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 82.196%

Totals Coverage Status
Change from base Build 8718170328: 0.05%
Covered Lines: 277
Relevant Lines: 337

💛 - Coveralls

@BiKodes BiKodes force-pushed the fix-profile-sync-data-members branch 3 times, most recently from 48fec51 to 3219a97 Compare April 17, 2024 12:04
@BiKodes BiKodes force-pushed the fix-profile-sync-data-members branch from 3219a97 to 6b761ce Compare April 18, 2024 06:49
@BiKodes BiKodes marked this pull request as ready for review April 18, 2024 06:52
@Muchogoc Muchogoc merged commit 9339923 into main Apr 18, 2024
2 checks passed
@robinmuhia robinmuhia deleted the fix-profile-sync-data-members branch June 19, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants