Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow empty email in registration input #59

Merged
merged 1 commit into from Aug 7, 2021
Merged

Conversation

Muchogoc
Copy link
Member

@Muchogoc Muchogoc commented Aug 7, 2021

Review Checklist

Bugs
Features
Tests

Summary*

  • fix: Bug fix for Add the items tackled here as checklists
  • feat: Completed task
  • chore: Incomplete task
    • test: Sub-task 1

Structure*

  • The Pull Request has a proper title that conforms to our MR title standards
  • The Pull Request has one commit, and if there are more than one, they should be squashed
  • The commit should have a proper title and a short description
  • The commit must be signed off
  • Unused imports are not present
  • Dead code is not present
  • Ensure dry running library to confirm changes

Tests

  • Proper and high quality unit, integration and acceptance(if applicable) tests have been written
  • The coverage threshold should not be lowered

Sign off*

  • All comments have been resolved by the reviewers
  • Approved by Czar {replace_with_czar_name}
  • Signed off by second reviewer {replace_with_name}
  • Ensure all checks are done before merging ⚠️
  • All PRs needs to be signed before merging ⚠️

N/B:

  • Add a checklist if more than one item is done.
  • Add screenshots and/or images where necessary
  • Indicate any breakages caused in the UI ❗
  • Where necessary, indicate which issue the Pull Request solves (Closes #)
  • Any new files are updated in the folder structure in the README

@NYARAS NYARAS merged commit 819fa7d into develop Aug 7, 2021
@NYARAS NYARAS deleted the fix-email-input branch August 7, 2021 16:43
Muchogoc added a commit that referenced this pull request Aug 18, 2021
* fix: allow empty email in registration input (#59)

* feat: autolink covers for sladers who receive an SMS from EDI (#44)

* feat: isc endpoint to check for permission (#60)

- feat: retrive users with a role, get role by name
- chore: remove unused role usecases

* test: fix tests for getting navigation actions usecase (#53)

* chore: filter roles using filter input struct (#57)

* fix: ensure that returned navigation actions are in the order required (#58)

* chore: update email templates (#62)

Co-authored-by: Willard Shikami <shikami@savannahinformatics.com>

* ref: ordering navigation actions using priority (#68)

- chore: add employee navigation actions

* fix: change role filter to search role by role name (#67)

* chore: update registered user welcome message (#70)

fix: return empty list for missing role in role search

* feat: add permission scopes in login response (#69)

* feat: layout community onboarding service deployment (#72)

* feat: layout community onboarding service deployment

[ ] Build and push docker image to GCR
[ ] Deploy the revision to Cloud Run via CI
[ ] Make this workflow stage depend on CI test and lint workflow

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* feat: for lint and test workflow to complete and succeed before running deployment workflow

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* configure enviroment and job concurrency group

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* fix: flagged feature disabled on token refresh (#75)

* refactor purge user (#77)

* feat: add service deployment job (#74)

[ ] Deploy test server to Google Cloud Run
[ ] Supply secrets via Google Secret Manager

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

Co-authored-by: Charles Muchogo <48381664+Muchogoc@users.noreply.github.com>
Co-authored-by: Salaton <nairouasalaton@gmail.com>
Co-authored-by: Richard Ochom <ochomrichard752@gmail.com>
Co-authored-by: Shikami <46521311+willshikami@users.noreply.github.com>
Co-authored-by: Willard Shikami <shikami@savannahinformatics.com>
Co-authored-by: Kennedy Kori <kennedykori47@gmail.com>
Co-authored-by: Kathurima Kimathi <41376826+KathurimaKimathi@users.noreply.github.com>
NYARAS added a commit that referenced this pull request Aug 19, 2021
* fix: allow empty email in registration input (#59)

* feat: autolink covers for sladers who receive an SMS from EDI (#44)

* feat: isc endpoint to check for permission (#60)

- feat: retrive users with a role, get role by name
- chore: remove unused role usecases

* test: fix tests for getting navigation actions usecase (#53)

* chore: filter roles using filter input struct (#57)

* fix: ensure that returned navigation actions are in the order required (#58)

* chore: update email templates (#62)

Co-authored-by: Willard Shikami <shikami@savannahinformatics.com>

* ref: ordering navigation actions using priority (#68)

- chore: add employee navigation actions

* fix: change role filter to search role by role name (#67)

* chore: update registered user welcome message (#70)

fix: return empty list for missing role in role search

* feat: add permission scopes in login response (#69)

* feat: layout community onboarding service deployment (#72)

* feat: layout community onboarding service deployment

[ ] Build and push docker image to GCR
[ ] Deploy the revision to Cloud Run via CI
[ ] Make this workflow stage depend on CI test and lint workflow

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* feat: for lint and test workflow to complete and succeed before running deployment workflow

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* configure enviroment and job concurrency group

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* fix: flagged feature disabled on token refresh (#75)

* refactor purge user (#77)

* feat: add service deployment job (#74)

[ ] Deploy test server to Google Cloud Run
[ ] Supply secrets via Google Secret Manager

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* chore: add gitguardian security check and limit deployment to test servers to only develop branch (#78)

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

Co-authored-by: Charles Muchogo <48381664+Muchogoc@users.noreply.github.com>
Co-authored-by: Salaton <nairouasalaton@gmail.com>
Co-authored-by: Richard Ochom <ochomrichard752@gmail.com>
Co-authored-by: Shikami <46521311+willshikami@users.noreply.github.com>
Co-authored-by: Willard Shikami <shikami@savannahinformatics.com>
Co-authored-by: Otieno Calvine <35563516+NYARAS@users.noreply.github.com>
Co-authored-by: Kennedy Kori <kennedykori47@gmail.com>
Muchogoc added a commit that referenced this pull request Sep 8, 2021
* fix: allow empty email in registration input (#59)

* feat: autolink covers for sladers who receive an SMS from EDI (#44)

* feat: isc endpoint to check for permission (#60)

- feat: retrive users with a role, get role by name
- chore: remove unused role usecases

* test: fix tests for getting navigation actions usecase (#53)

* chore: filter roles using filter input struct (#57)

* fix: ensure that returned navigation actions are in the order required (#58)

* chore: update email templates (#62)

Co-authored-by: Willard Shikami <shikami@savannahinformatics.com>

* ref: ordering navigation actions using priority (#68)

- chore: add employee navigation actions

* fix: change role filter to search role by role name (#67)

* chore: update registered user welcome message (#70)

fix: return empty list for missing role in role search

* feat: add permission scopes in login response (#69)

* feat: layout community onboarding service deployment (#72)

* feat: layout community onboarding service deployment

[ ] Build and push docker image to GCR
[ ] Deploy the revision to Cloud Run via CI
[ ] Make this workflow stage depend on CI test and lint workflow

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* feat: for lint and test workflow to complete and succeed before running deployment workflow

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* configure enviroment and job concurrency group

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* fix: flagged feature disabled on token refresh (#75)

* refactor purge user (#77)

* feat: add service deployment job (#74)

[ ] Deploy test server to Google Cloud Run
[ ] Supply secrets via Google Secret Manager

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* chore: add gitguardian security check and limit deployment to test servers to only develop branch (#78)

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* fix: set-env-vars for root collection suffix (#81)

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* tests: role management integration and acceptance tests (#63)

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* fix: root collection and sentry dns env (#83)

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* feat: listing role members in role output and role details in user response (#84)

- assigning multiple roles

* feat: add and save role revocation reason (#73)

chore: roles in admin and agent response

* feat: add AgentProfile to users registered as agents (#76)

* feat: add searching admin by phone (#79)

* feat: add sending temporary pin to users on demand (#54)

* Revert "feat: add sending temporary pin to users on demand (#54)" (#89)

This reverts commit 1ff99b7.

* chore: add ci schema validation command (#88)

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* chore: remove test roles (#90)

* feat: add register user rest endpoint (#105)

* feat: add register user rest endpoint (#115)

* feat: add register user rest endpoint (#116)

* chore: make createdByID an optional attribute when creating a user profile (#124)

* chore: remove email address as required user response (#127)

* fix: add a fix for empty navaction onTapRoutes (#128)

* chore: add consumer registration route (#130)

* fix: add required permission to consumer navigation action (#133)

Co-authored-by: Charles Muchogo <48381664+Muchogoc@users.noreply.github.com>
Co-authored-by: Salaton <nairouasalaton@gmail.com>
Co-authored-by: Richard Ochom <ochomrichard752@gmail.com>
Co-authored-by: Shikami <46521311+willshikami@users.noreply.github.com>
Co-authored-by: Willard Shikami <shikami@savannahinformatics.com>
Co-authored-by: Kennedy Kori <kennedykori47@gmail.com>
Co-authored-by: Kathurima Kimathi <41376826+KathurimaKimathi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants