Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release develop to main #80

Merged
merged 17 commits into from Aug 19, 2021
Merged

release develop to main #80

merged 17 commits into from Aug 19, 2021

Conversation

KathurimaKimathi
Copy link
Contributor

Review Checklist

Bugs
Features
Tests

Summary*

  • fix: Bug fix for Add the items tackled here as checklists
  • feat: Completed task
  • chore: Incomplete task
    • test: Sub-task 1

Structure*

  • The Pull Request has a proper title that conforms to our MR title standards
  • The Pull Request has one commit, and if there are more than one, they should be squashed
  • The commit should have a proper title and a short description
  • The commit must be signed off
  • Unused imports are not present
  • Dead code is not present
  • Ensure dry running library to confirm changes

Tests

  • Proper and high quality unit, integration and acceptance(if applicable) tests have been written
  • The coverage threshold should not be lowered

Sign off*

  • All comments have been resolved by the reviewers
  • Approved by Czar {replace_with_czar_name}
  • Signed off by second reviewer {replace_with_name}
  • Ensure all checks are done before merging ⚠️
  • All PRs needs to be signed before merging ⚠️

N/B:

  • Add a checklist if more than one item is done.
  • Add screenshots and/or images where necessary
  • Indicate any breakages caused in the UI ❗
  • Where necessary, indicate which issue the Pull Request solves (Closes #)
  • Any new files are updated in the folder structure in the README

Muchogoc and others added 17 commits August 18, 2021 16:18
- feat: retrive users with a role, get role by name
- chore: remove unused role usecases
Co-authored-by: Willard Shikami <shikami@savannahinformatics.com>
- chore: add employee navigation actions
fix: return empty list for missing role in role search
* feat: layout community onboarding service deployment

[ ] Build and push docker image to GCR
[ ] Deploy the revision to Cloud Run via CI
[ ] Make this workflow stage depend on CI test and lint workflow

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* feat: for lint and test workflow to complete and succeed before running deployment workflow

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>

* configure enviroment and job concurrency group

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>
[ ] Deploy test server to Google Cloud Run
[ ] Supply secrets via Google Secret Manager

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>
…rvers to only develop branch (#78)

Signed-off-by: Otieno Calvine <nyarangaotieno@gmail.com>
@NYARAS NYARAS merged commit 642dc8a into main Aug 19, 2021
@NYARAS NYARAS temporarily deployed to test August 19, 2021 07:21 Inactive
@NYARAS NYARAS temporarily deployed to test August 19, 2021 07:24 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants