chore(retry): rename the exponential_backoff_retry logger
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly set the name of the `Logger` used by instances of the `Retry` policies returned by the `exponential_backoff_retry` factory function. The name of the logger is now the same as the factory function used to create those instances, i.e. `exponential_backoff_retry`. This should improve the readability of the logs and hide the names of internal non-public classes and functions that make up the aforementioned `Retry` policy.
kennedykori
force-pushed
the
chore-rename-exponential-back-off-retry-logger
branch
from
848f264
to
409392b
Compare
kennedykori
added a commit
that referenced
this pull request
Jul 13, 2024
Explicitly set the name of the `Logger` used by instances of the `Retry` policies returned by the `exponential_backoff_retry` factory function. The name of the logger is now the same as the factory function used to create those instances, i.e. `exponential_backoff_retry`. This should improve the readability of the logs and hide the names of internal non-public classes and functions that make up the aforementioned `Retry` policy.
kennedykori
added a commit
that referenced
this pull request
Jul 13, 2024
## [1.5.0-rc.1](v1.4.0...v1.5.0-rc.1) (2024-07-13) ### Bug Fixes * assorted fixes and improvements ([#44](#44)) ([c6f2723](c6f2723)) ### Dependency Updates * **deps:** upgrade project dependencies ([#46](#46)) ([d4cef75](d4cef75)) ### Features * **config:** add `setting_initializer` decorator ([#45](#45)) ([334f6be](334f6be)) * **utils:** make `type_fqn` support callable instances ([#43](#43)) ([b22c835](b22c835)) ### Refactors * **retry:** rename the `exponential_backoff_retry` logger ([#42](#42)) ([de03e2c](de03e2c))
kennedykori
added a commit
that referenced
this pull request
Jul 13, 2024
Explicitly set the name of the `Logger` used by instances of the `Retry` policies returned by the `exponential_backoff_retry` factory function. The name of the logger is now the same as the factory function used to create those instances, i.e. `exponential_backoff_retry`. This should improve the readability of the logs and hide the names of internal non-public classes and functions that make up the aforementioned `Retry` policy.
kennedykori
added a commit
that referenced
this pull request
Jul 13, 2024
## [1.5.0-rc.1](v1.4.0...v1.5.0-rc.1) (2024-07-13) ### Bug Fixes * assorted fixes and improvements ([#44](#44)) ([c6f2723](c6f2723)) ### Dependency Updates * **deps:** upgrade project dependencies ([#46](#46)) ([d4cef75](d4cef75)) ### Features * **config:** add `setting_initializer` decorator ([#45](#45)) ([334f6be](334f6be)) * **utils:** make `type_fqn` support callable instances ([#43](#43)) ([b22c835](b22c835)) ### Refactors * **retry:** rename the `exponential_backoff_retry` logger ([#42](#42)) ([de03e2c](de03e2c))
kennedykori
added a commit
that referenced
this pull request
Jul 13, 2024
## [1.5.0](v1.4.0...v1.5.0) (2024-07-13) ### Bug Fixes * assorted fixes and improvements ([#44](#44)) ([5928f9b](5928f9b)) ### Dependency Updates * **deps:** upgrade project dependencies ([#46](#46)) ([a48947a](a48947a)) ### Features * **config:** add `setting_initializer` decorator ([#45](#45)) ([b655527](b655527)) * **utils:** make `type_fqn` support callable instances ([#43](#43)) ([fa13030](fa13030)) ### Refactors * **deps-dev:** bump braces from 3.0.2 to 3.0.3 ([#48](#48)) ([645060d](645060d)) * **retry:** rename the `exponential_backoff_retry` logger ([#42](#42)) ([a3d30b6](a3d30b6))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly set the name of the
Loggerused by instances of theRetrypolicies returned by theexponential_backoff_retryfactory function. The name of the logger is now the same as the factory function used to create those instances, i.e.exponential_backoff_retry.This should improve the readability of the logs and hide the names of internal non-public classes and functions that make up the aforementioned
Retrypolicy.