Fixed PreviewAnnotationRule #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: - moved creating private node to ASTFactory - added a new node to ANNOTATION_LIST It's part of 1737
nulls
requested review from
kgevorkyan,
DrAlexD,
orchestr7 and
0x6675636b796f75676974687562
Codecov Report
@@ Coverage Diff @@
## master #1740 +/- ##
============================================
+ Coverage 74.76% 75.00% +0.23%
- Complexity 2270 2274 +4
============================================
Files 126 126
Lines 8230 8233 +3
Branches 2072 2066 -6
============================================
+ Hits 6153 6175 +22
+ Misses 1163 1142 -21
- Partials 914 916 +2
|
kgevorkyan
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
It's part of #1737