Initialize subprojects and command-line interface #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # build.gradle.kts # buildSrc/build.gradle.kts
### What's done: * Fixes
### What's done: * Fixes
petertrr
changed the title
### What's done: * Code style
petertrr
force-pushed
the
feature/base-core-cli
branch
from
354af55
to
1e944f5
Compare
### What's done: * Added talaiot and versions plugin * Changed version of junit dependency
### What's done: * Added opt-in for okio FS API
orchestr7
reviewed
Mar 22, 2021
orchestr7
reviewed
Mar 22, 2021
orchestr7
reviewed
Mar 22, 2021
save-core/src/commonMain/kotlin/org/cqfn/save/core/config/ReportType.kt
Outdated
Show resolved
Hide resolved
orchestr7
reviewed
Mar 22, 2021
| * @param args CLI args | ||
| * @return an instance of [SaveConfig] | ||
| */ | ||
| fun createConfigFromArgs(args: Array<String>): SaveConfig { |
There was a problem hiding this comment.
may be will add some argument for a baseline? (while I haven't yet forgotten about that)
We should have a baseline functionality
There was a problem hiding this comment.
Added this and addressed other comments, please take a look
orchestr7
requested changes
Mar 22, 2021
### What's done: * Fixes
### What's done: * Code style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
Closes #2