Fix zeroth in Dutch to nulde fixing #325 #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2884042153
💛 - Coveralls |
2 tasks
|
@mromdhane could this be merged or is a new / updated pull request necessary ? |
|
@KommuSoft hello and thanks for the contribution |
Remove an unnecessary condition, since the very same action follows it.
…r options not implemented.
* [tr] return Turkish 0 ordinal and cardinal * add str_to_number to Turkish * try rather use Num2Word_Base
…SR languages (savoirfairelinux#400) * Fix English char 'i' in Ukrainian words * Fix the feminine currency processing for UAH in lang_UK.py * Fix test_ua.py * Fix the feminine currency processing for UAH in lang_RU.py * Add tests for UAH in test_ru.py * Add world currencies to lang_UK.py; Add test cases to test_uk.py for world currencies * Fix incorrect handling of zeros after decimal point for CZ, KZ, LT, LV, PL, RU, SR and UK languages * Add ukrainian ordinal numbers * Fix too long lines of code * Add test for negative cardinal number
…es); fixed accents in test_es.py (dieciséis, dólar, dólares, veintiún)
Fixed: ./num2words/lang_ES.py:366:56: E261 at least two spaces before inline comment ./num2words/lang_ES.py:366:80: E501 line too long (100 > 79 characters)
Fixed accent in Spanish examples ("centimos"->"céntimos"), thus making the example consistent with actual current behaviour.
Fixed accent in Spanish command line examples ("centimos"->"céntimos"), thus making the example consistent with actual current behaviour.
remove space
Done! |
mrodriguezg1991
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #325 by Willem Van Onsem
Changes proposed in this pull request:
Status
How to verify this change
Added a testcase in
tests/test_nl.py. One can validate that this is the correct ordinal on https://en.wiktionary.org/wiki/nulde