Support Arabic

[dalwadani]

Add Arabic support:

>>> from num2words import num2words
>>> num2words(42, lang="ar")
'اثنين وأربعين'
>>> 

[erozqba]

Hello @dalwadani
Thanks for taking the time to add Arabic support into mun2words.
Could you please fix the encoding problem for Python 2.7 and add some test for Arabic like the one that exists for the other languages inside the tests directory?

[dalwadani]

Done!

[jerem]

Can this be merged/released now?

[erozqba]

I don't know Arabic myself, so we really trust new contributions. Overall this looks goods, only two small comments. Thanks again for your time I will merge it when I have your feedback about the comments.

[erozqba]

I don't know any Arabic, but I don't think that you use "hundred" and "and", could you check this, please?

[erozqba]

The same here, I see "dollar/s", "cent/s", "and".

[erozqba]

@dalwadani Sorry for taking too long in the review, could you please check the comments? Thanks!

[dalwadani]

Done!

[erozqba]

Thanks @dalwadani !

[jerem]

Thanks both of you!
@erozqba When can we expect a new release including this change?

[erozqba]

@jerem I will ask the main maintainer @hsoft about a new release as soon as possible.

[ghost]

@dufresnedavid is the maintainer of the package now.

[ghost]

@hsoft Sorry, when I told you that I would maintain this repo, I was a bit out of context.

num2words is not relevant for Odoo development since Odoo version 9.0 (an equivalent of num2words is available directly in the source code of Odoo). Therefore, I don't see myself fit has maintainer of this project because I won't use it at all.

I would suggest @erozqba to take the flag.

[erozqba]

@hsoft I have made a new release v0.5.5. I try to publish it in https://pypi.python.org/pypi but I'm not allowed I get this error: Server response (403): You are not allowed to store 'num2words' package information
I have tested the release on the test server of PyPi, you could check it here: https://testpypi.python.org/pypi/num2words

Thanks in advance for your help and any suggestions or changes that must be made to the release.

[ghost]

@erozqba I don't have permissions to publish PyPI packages under the SFL account any more so I can't help you much, but we had set up PyPI permissions with @dufresnedavid before I left.

[erozqba]

@jerem I have released the version v0.5.5