Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with encoder type inference #2773

Closed
toots opened this issue Dec 4, 2022 · 0 comments · Fixed by #2782
Closed

Bug with encoder type inference #2773

toots opened this issue Dec 4, 2022 · 0 comments · Fixed by #2782
Assignees

Comments

@toots
Copy link
Member

toots commented Dec 4, 2022

def g() =
  s = single("foo")

  s = s

  enc = %ffmpeg(
    format="mkv",
    %audio(codec="aac"),
    %video(codec="aac")
  )

  output.file(fallible=true, enc, "/tmp/bla.mkv", s)

  (s, enc)
end

Gives:

g :
  () ->
  source('a) * format(audio=pcm(stereo), video=canvas) = <fun>

While:

def g() =
  s = single("foo")

  #s = s

  enc = %ffmpeg(
    format="mkv",
    %audio(codec="aac"),
    %video(codec="aac")
  )

  output.file(fallible=true, enc, "/tmp/bla.mkv", s)

  (s, enc)
end

Gives, as expected:

g :
  () ->
  source(audio=pcm(stereo), video=canvas) * format(audio=pcm(stereo), video=canvas) = <fun>
toots added a commit that referenced this issue Dec 8, 2022
toots added a commit that referenced this issue Dec 8, 2022
toots added a commit that referenced this issue Dec 8, 2022
It looks like pattern types need to be generalized at the same level as the current execution. Fixes: #2773
toots added a commit that referenced this issue Dec 8, 2022
It looks like pattern types need to be generalized at the same level as the current execution. Fixes: #2773
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants