Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize pattern types at the same level as current code #2782

Merged
merged 1 commit into from Dec 8, 2022

Conversation

toots
Copy link
Member

@toots toots commented Dec 8, 2022

Fixes: #2773

@toots toots marked this pull request as ready for review December 8, 2022 14:46
@toots toots requested a review from smimram December 8, 2022 14:46
@toots toots force-pushed the pattern-type-generalization branch from 753f9f7 to 059c136 Compare December 8, 2022 14:51
Copy link
Member

@smimram smimram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, thanks for spotting this!!

@toots toots merged commit 6da1521 into main Dec 8, 2022
@toots toots deleted the pattern-type-generalization branch December 8, 2022 16:25
toots added a commit that referenced this pull request Dec 8, 2022
It looks like pattern types need to be generalized at the same level as the current execution. Fixes: #2773
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with encoder type inference
2 participants