Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http.post.file use different variable for timeout and different defaults from the others http.post params #2809

Closed
cdgraff opened this issue Dec 28, 2022 · 1 comment · Fixed by #2920

Comments

@cdgraff
Copy link

cdgraff commented Dec 28, 2022

Inside http.post and http.post.stream variable is called timeout_ms and has 10000 as the default

timeout_ms (of type int?, which defaults to 10000): Timeout for network operations in milliseconds.

Insidehttp.post.file variable is called timeout and is NULL as default

timeout (of type int?, which defaults to null): Timeout in ms.

Will be good normalize to easy and clean writing

thanks!

@toots
Copy link
Member

toots commented Dec 28, 2022

Hi,

That's a great suggestion! Have you ever tried to contribute to the code? This would be an easy one to pick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants