Turn all timeout into float values in seconds #2920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toots
force-pushed
the
timeout-float-sec
branch
3 times, most recently
from
d7b0730
to
9e8ffe1
Compare
toots
force-pushed
the
timeout-float-sec
branch
from
9e8ffe1
to
7a9d53c
Compare
|
NB : it won't be a breaking change if you merge #2887 :) |
|
Well the change from milliseconds to seconds is gonna make things break still.. |
smimram
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a breaking change but I think that it would prove valuable: require that all timeout settings and parameters be labelled
timeout(orread_timeoutetc) and hold a floating point value in seconds.Fixes: #2809