Support for other SSL certificate keys, not only RSA #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogerleite
added a commit
that referenced
this pull request
Jun 24, 2014
Support for other SSL certificate keys, not only RSA
|
Good call, we definitely needed a release with some of the changes coming through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is many key types in the wild: RSA, DSA, EC, DH.
We're currently working with service, that requires HTTPS with GOST encryption and client certificate authentication. So, we need to specify GOST R 34.10-2001 certificate and keys, but HTTPI currently allows to use only RSA keys.
GOST R 34.10-2001 are treated as EC keys with our current patches for Ruby, but it may change in future.
This PR fixes this by letting Ruby itself decide what the type provided key is (it doing this here, called from
OpenSSL::PKey.read: https://github.com/ruby/ruby/blob/trunk/ext/openssl/ossl_pkey.c#L76)P.S> Please, also merge savonrb/savon#588, we need this functionality to use from savon.