Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ssl to dynamically introspect ssl version from openssl #136

Conversation

saghaulor
Copy link
Contributor

No description provided.

…ERSIONS.

- Doing it this way makes HTTPI compatible with Ruby 1.9.x-2.1.x
- It will automatically pick up newer TLS versions.
- Based on my understanding, curl will use the best available version of
  TlS. I assume that curb does the same.
- In Ruby 2.x there are SSLv3 and SSLv23. I assume that SSLv23 would be
  the only option for SSLv2.
- Since we're no longer hard coding values, our tests need to account
  for that.
- A few tests were removed for a single generic test as we really only
  need to test a getter and setter once, rather than testing for every
  possible value.
@tjarratt
Copy link
Contributor

Thanks for submitting this pull request @saghaulor!

Not hardcoding the available SSL versions is great, and I'm pleasantly surprised to see that this still works on travis-ci. My initial concern would be that adding this runtime dependency would make the tests dependent on a particular version of openssl, but it seems like travis has a relatively modern version, and all of the machines I tested this on seemed to as well.

tjarratt added a commit that referenced this pull request Nov 12, 2014
…trospect_ssl_version_from_openssl

Refactor ssl to dynamically introspect ssl version from openssl
@tjarratt tjarratt merged commit 1f5d41e into savonrb:master Nov 12, 2014
@tjarratt
Copy link
Contributor

Released v2.3.0 from commit ba5d04f -- will take a look at pulling that into Savon shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants