Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Net::HTTP::Persistent v4 #213

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

Meat-Chopper
Copy link
Contributor

Currently HTTPI doesn't support net-http-persistent v 4.0.0. This pull request fixes it.

Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When comparing version numbers, we can use Gem:: Version.new around the involved version specifiers. How do you feel about that?

@Meat-Chopper
Copy link
Contributor Author

Thank you for the comment! It has been applied.

@rogerleite
Copy link
Member

Hey @Meat-Chopper, thanks for the contribution and @olleolleolle for the suggestion.

Somebody, please check why CI is failing?
Don't seem related to the change you did but I don't have time to check it now.

Thanks in advance.

@olleolleolle
Copy link
Contributor

Looks like:
This branch is using Rake 10.x (old). And an old code coverage library version (perhaps old).

The test failure unrelated to that, has this in there: a Puma-wrapped SSL failure.


/home/travis/.rvm/gems/ruby-2.7.1/gems/puma-2.3.2/lib/puma/minissl.rb:32:in `read': OpenSSL error: error:00000001:lib(0):func(0):reason(1) - 1 (Puma::MiniSSL::SSLError)

.Exception handling servers: OpenSSL error: error:00000001:lib(0):func(0):reason(1) - 1 (Puma::MiniSSL::SSLError)


This takes more investigation & I'm far from computers for at least 10 days.

Hope these notes help!

@olleolleolle
Copy link
Contributor

@Meat-Chopper Hi again! The issue has been resolved, and if you rebase this change, you'll see the code looks a little different, now.

@coveralls
Copy link

coveralls commented Nov 16, 2020

Coverage Status

Coverage decreased (-0.006%) to 97.068% when pulling 8482304 on Meat-Chopper:persistent_v4 into 91d2d19 on savonrb:master.

@Meat-Chopper
Copy link
Contributor Author

Hello @olleolleolle,
The rebase has been done. Thank you for fixing CI!

@rogerleite
Copy link
Member

Thanks @olleolleolle for fixing the CI
@Meat-Chopper thanks for the contribution

@rogerleite rogerleite merged commit 497a304 into savonrb:master Nov 16, 2020
@olleolleolle
Copy link
Contributor

No glory belongs to me, @c960657 fixed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants