-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Net::HTTP::Persistent v4 #213
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When comparing version numbers, we can use Gem:: Version.new around the involved version specifiers. How do you feel about that?
Thank you for the comment! It has been applied. |
Hey @Meat-Chopper, thanks for the contribution and @olleolleolle for the suggestion. Somebody, please check why CI is failing? Thanks in advance. |
Looks like: The test failure unrelated to that, has this in there: a Puma-wrapped SSL failure. /home/travis/.rvm/gems/ruby-2.7.1/gems/puma-2.3.2/lib/puma/minissl.rb:32:in `read': OpenSSL error: error:00000001:lib(0):func(0):reason(1) - 1 (Puma::MiniSSL::SSLError) .Exception handling servers: OpenSSL error: error:00000001:lib(0):func(0):reason(1) - 1 (Puma::MiniSSL::SSLError) This takes more investigation & I'm far from computers for at least 10 days. Hope these notes help! |
@Meat-Chopper Hi again! The issue has been resolved, and if you rebase this change, you'll see the code looks a little different, now. |
Applied comment
3b65ecd
to
8482304
Compare
Hello @olleolleolle, |
Thanks @olleolleolle for fixing the CI |
No glory belongs to me, @c960657 fixed it! |
Currently HTTPI doesn't support
net-http-persistent
v 4.0.0. This pull request fixes it.