-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Savon version 2 requests #7
Closed
Closed
Commits on Apr 16, 2013
-
Clean up Gemfile, use https for rubygems
It's unlikely that anyone will ever be MITM'd and receive a bad gem, but it's a best practice to use ssl for installing gems
Configuration menu - View commit details
-
Copy full SHA for c086afe - Browse repository at this point
Copy the full SHA c086afeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 165e86a - Browse repository at this point
Copy the full SHA 165e86aView commit details -
Refactor savon-multipart for Savon2
Needs tests but the interface between savon-multipart and savon just became a whole lot smaller.
Configuration menu - View commit details
-
Copy full SHA for ac02c04 - Browse repository at this point
Copy the full SHA ac02c04View commit details -
This isn't necessary anymore because Savon does not have a global configuration manager in version 2. Instead, when you instantiate a client, you have an option to pass in some options there, and you can also pass in options (that will take precedence over the previous ones) when you call the #call method on a Savon::Client Neat, and with way less global state than before. Either way, this spec helper isn't needed anymore.
Configuration menu - View commit details
-
Copy full SHA for d3f1c87 - Browse repository at this point
Copy the full SHA d3f1c87View commit details -
Nothing crazy, just changed how we create the response
Configuration menu - View commit details
-
Copy full SHA for 41b1c1b - Browse repository at this point
Copy the full SHA 41b1c1bView commit details
Commits on May 1, 2013
-
Tim Jarratt committed
May 1, 2013 Configuration menu - View commit details
-
Copy full SHA for 76afc55 - Browse repository at this point
Copy the full SHA 76afc55View commit details -
Add tests for the #body and #to_xml methods
I had previously only been using the #to_xml and #parts methods, so I hadn't run this this before. The issue was that Nori does not know how to handle an instance of Mail::Body rather than a string. It seems that the correct thing to do is to just return a string. Also brought in some same defaults from Savon::GlobalOptions for this test. Before it wouldn't have been possible to actually call the #body method in the tests because we didn't specify how to take the response body tags and turn them into snakecase symbols
Tim Jarratt committedMay 1, 2013 Configuration menu - View commit details
-
Copy full SHA for cb90ee4 - Browse repository at this point
Copy the full SHA cb90ee4View commit details
Commits on May 7, 2013
-
Unsure whether this will pass on ree, but it will pass on all supported versions of 1.8.7 (p371 mri, jruby18-mode and rubinius).
tjarratt@gmail.com authored and tjarratt@gmail.com committedMay 7, 2013 Configuration menu - View commit details
-
Copy full SHA for 8f6f947 - Browse repository at this point
Copy the full SHA 8f6f947View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.