Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Savon version 2 requests #7

Closed
wants to merge 8 commits into from

Commits on Apr 16, 2013

  1. Clean up Gemfile, use https for rubygems

    It's unlikely that anyone will ever be MITM'd and receive a bad gem, but
    it's a best practice to use ssl for installing gems
    tjarratt committed Apr 16, 2013
    Configuration menu
    Copy the full SHA
    c086afe View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    165e86a View commit details
    Browse the repository at this point in the history
  3. Refactor savon-multipart for Savon2

    Needs tests but the interface between savon-multipart and savon just became a
    whole lot smaller.
    tjarratt committed Apr 16, 2013
    Configuration menu
    Copy the full SHA
    ac02c04 View commit details
    Browse the repository at this point in the history
  4. Remove spec_helper

    This isn't necessary anymore because Savon does not have a global configuration
    manager in version 2. Instead, when you instantiate a client, you have an option
    to pass in some options there, and you can also pass in options (that will take
    precedence over the previous ones) when you call the #call method on a Savon::Client
    
    Neat, and with way less global state than before. Either way, this spec helper isn't
    needed anymore.
    tjarratt committed Apr 16, 2013
    Configuration menu
    Copy the full SHA
    d3f1c87 View commit details
    Browse the repository at this point in the history
  5. Update rspec tests

    Nothing crazy, just changed how we create the response
    tjarratt committed Apr 16, 2013
    Configuration menu
    Copy the full SHA
    41b1c1b View commit details
    Browse the repository at this point in the history

Commits on May 1, 2013

  1. Cleanup some whitespace

    Tim Jarratt committed May 1, 2013
    Configuration menu
    Copy the full SHA
    76afc55 View commit details
    Browse the repository at this point in the history
  2. Add tests for the #body and #to_xml methods

    I had previously only been using the #to_xml and #parts methods, so I hadn't
    run this this before. The issue was that Nori does not know how to handle an
    instance of Mail::Body rather than a string. It seems that the correct thing
    to do is to just return a string.
    
    Also brought in some same defaults from Savon::GlobalOptions for this test.
    Before it wouldn't have been possible to actually call the #body method in
    the tests because we didn't specify how to take the response body tags and
    turn them into snakecase symbols
    Tim Jarratt committed May 1, 2013
    Configuration menu
    Copy the full SHA
    cb90ee4 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2013

  1. Update tests to pass on 1.8.7

    Unsure whether this will pass on ree, but it will pass on all
    supported versions of 1.8.7 (p371 mri, jruby18-mode and rubinius).
    tjarratt@gmail.com authored and tjarratt@gmail.com committed May 7, 2013
    Configuration menu
    Copy the full SHA
    8f6f947 View commit details
    Browse the repository at this point in the history