Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for handling an array of identically-named elements #218

Closed
wants to merge 3 commits into from

Conversation

tbauscher
Copy link

This is a fix for handling an array of identically-named elements, like so:

{ :attribute_names => { "string" => ["some", "array"] } }

Without the fix, the array is converted to a string.

@rubiii
Copy link
Contributor

rubiii commented Aug 22, 2011

could you add specs for this?

rubiii added a commit that referenced this pull request Aug 24, 2011
namespaced array items were converted to a string instead of being
properly converted to xml nodes.
@rubiii
Copy link
Contributor

rubiii commented Aug 24, 2011

thanks drew for writing a spec for this, but unfortunately the problem involves namespaces and had to be tested in a different way. so i used the taxcloud wsdl and finally fixed the issue: rubiii/savon@0e346977

thanks again. i'm going to release this along with a couple other bugfixes asap.

@rubiii rubiii closed this Aug 24, 2011
rubiii added a commit that referenced this pull request Aug 24, 2011
once again, ordered hashes are missing. but this should be enough to
verify the expected behaviour.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants