Add namespaces to body and order #275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this we might run into "Missing elements in :order!" errors from Gyoku.
|
merged. thanks jakob! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a Hash to construct the SOAP body and forcing the order of elements with
:order!and the body elements are namespaced, Gyoku raises anArgumentError:Savon::SOAP::XML#add_namespaces_to_bodyadds namespaces to the names of elements in the SOAP body, causing them to become out of sync with the element names in the :order! list.These changes add namespaces to the values in :order! elements as well, so the names match their counterparts in the body Hash before being sent off to Gyoku.
They also add a few tests for the private
add_namespaces_to_bodymethod, which was far the easiest way to setup tests for this case.Fixes #238.