Encode message in encoding specified in globals

[skorbut]

Currently the encoding is only set on the request, but the message isn't actually converted. This leads to errors with german umlauts (For example in addressdata).

[rubiii]

hey @skorbut,

although this looks to be "the right thing to do", it's a rather big change and i'm not sure if it just saves people from encoding the message themselves or if they actually need to do it manually.

[skorbut]

Hi @rubiii,

I just looked for the best place to encode the whole soap request in one small step. We have quite big hashes, that I don't want to traverse recursively. Shall we add another global option to whether encode using the provided encoding?

[rubiii]

a new option would certainly be an option. maybe something like :encode_message => true?

[rubiii]

i was planning to release this with v2.3.0. so i fixed the implementation and specs to work on 1.8 when i noticed there's also one failing spec for jruby. so i reverted it for now.

this needs to be updated against savon's version 2 branch and fixed to raise an error for 1.8 and jruby.

[skorbut]

Hi,
this is an issue of jruby jruby/jruby#856 and is addressed in JRuby 1.7.5. Currently unrecognized characters are always replaced by a ? instead of the string provided to the encode method. I don't want to remove this spec, but may set it to pending until jruby 1.7.5 is used.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue is now closed due to inactivity. If you believe this needs further action, please re-open to discuss.