Replace UUID with SecureRandom.uuid

[zcross]

Savon uses the uuid gem which does some pretty heavy lifting to generate UUIDs (e.g., shelling out via systemu). This PR removes this dependency, using Ruby's own SecureRandom.uuid.

[zanker]

From testing, it looks like it's not necessary to use the uuid gem, as long as Savon doesn't need to work on Ruby 1.8.7, which was EOL'd anyway.

http://www.w3.org/Submission/ws-addressing/ don't appear to require any particular format. The docs primarily reference that it's used to prevent replay attacks, which SecureRandom.uuid handles no problem.

[zcross]

Addendum: kudos to @zanker for pairing with me in debugging an issue that led to this proposed change.

[wyaeld]

@tjarratt any thoughts on this?

[tjarratt]

Thanks for the ping @wyaeld -- I had almost forgot about this thread.

I'm a huge fan of not shelling out in ruby, so this pull request is awesome. Many thanks to you, @zcross and @zanker!

[tjarratt]

From the changes, it seems that there's a vested interest in getting a new version of Savon published?

[wyaeld]

Yes please. About to start a new project

On Fri, Jun 5, 2015, 5:15 PM Tim Jarratt notifications@github.com wrote:

From the changes, it seems that there's a vested interest in getting a new
version of Savon published?

—
Reply to this email directly or view it on GitHub
#693 (comment).

[tjarratt]

I've just released Savon v2.11.1 -- enjoy!

[zcross]

Thanks!