Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global option ssl_ciphers #794

Merged
merged 5 commits into from
Nov 1, 2017
Merged

Add global option ssl_ciphers #794

merged 5 commits into from
Nov 1, 2017

Conversation

esambo
Copy link
Contributor

@esambo esambo commented Jan 21, 2017

Useful in combination with:

This allowed me to resolve following error:
SSL_connect SYSCALL returned=5 errno=0 state=SSLv2/v3 read server hello A

@anyakhvost
Copy link

This would be awesome! When do you think you will be merging this? @esambo

CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
# 2.12.0

* Freature: [#794](https://github.com/savonrb/savon/pull/794), add global option ssl_ciphers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hehe a typo Freature => Feature

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olleolleolle Thanks, I fixed the typo

Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a clearly expressed configuration option.

Thanks for adding it!

@pcai
Copy link
Member

pcai commented Nov 1, 2017

Thanks @esambo for contributing this. I needed to merge again from master for another merge conflict, will merge this in when that's green.

@pcai pcai merged commit 73eb888 into savonrb:master Nov 1, 2017
@c960657
Copy link

c960657 commented Nov 5, 2020

Useful in combination with:

  • global option ssl_version
  • savonrb/httpi#180: Implement HTTPI::Auth::SSL#ciphers configuration

Note that savonrb/httpi#180 was never merged (I don't know why — the PR was closed without explanation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants