Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String#snakecase in Wasabi breaks String#snakecase in Fat Free CRM #59

Closed
kukareka opened this issue May 18, 2015 · 2 comments
Closed

String#snakecase in Wasabi breaks String#snakecase in Fat Free CRM #59

kukareka opened this issue May 18, 2015 · 2 comments

Comments

@kukareka
Copy link

String#snakecase in Wasabi converts CamelCase strings to snake_case, but does not convert strings like "This week" to "this_week". It overwrites and breaks String#snakecase in Fat Free CRM (https://github.com/fatfreecrm/fat_free_crm/blob/master/lib/fat_free_crm/core_ext/string.rb).
This was referenced May 18, 2015
Closed
Closed
@rennhak
Copy link

rennhak commented May 18, 2015

+1

tjarratt added a commit that referenced this issue May 19, 2015
@tjarratt
Namespace String monkeypatches under Savon
c1933e9 
Closes #60 and #59

Many thanks to @kukareka for bringing this to my attention.
@tjarratt
Copy link
Contributor

Closed by c1933e9

@pcai pcai mentioned this issue Oct 17, 2022
Closed
@pcai pcai mentioned this issue Nov 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert spaces to underlines kukareka/wasabi
3 participants
@rennhak @tjarratt @kukareka