Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert spaces to underlines #60

Closed

Conversation

kukareka
Copy link

Convert strings like "This week" to "this_week" with String#snakecase.
Fix #59.

@tjarratt
Copy link
Contributor

I'm not sure if this is preferable to simply not polluting the String class with our monkey patches. For one, it doesn't seem likely that Wasabi would ever need to handle words with spaces in them, but it also seems like we should consistently use the same snakecase method, regardless of which order Savon and other projects are required in.

@tjarratt
Copy link
Contributor

I do appreciate the issue and the pull request though, @kukareka.

@tjarratt tjarratt closed this in c1933e9 May 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

String#snakecase in Wasabi breaks String#snakecase in Fat Free CRM
2 participants