Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated URI escape/unescape calls #74

Closed
wants to merge 1 commit into from
Closed

Remove deprecated URI escape/unescape calls #74

wants to merge 1 commit into from

Conversation

brittballard
Copy link

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling 95aaf08 on brittballard:savonrb/wasabi into 8cc2658 on savonrb:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling 95aaf08 on brittballard:savonrb/wasabi into 8cc2658 on savonrb:master.

@olleolleolle
Copy link
Contributor

@brittballard Hi! This seems to change behavior, and the test failures seem to be about escaping.

https://travis-ci.org/github/savonrb/wasabi/jobs/632112038#L283

Here's a StackOverflow note about the difference between the two methods: https://stackoverflow.com/questions/30783879/whats-the-difference-between-cgi-unescape-and-uri-decode-www-form-component

@olleolleolle
Copy link
Contributor

Aha, there's been additoinal fixes, in #75: f6ab0a5

@olleolleolle
Copy link
Contributor

Thanks for offering a PR! <3

Fixed in #81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brittballard @coveralls @olleolleolle