Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gemspec: Depend on addressable, for unescape #81

Merged

Conversation

olleolleolle
Copy link
Contributor

By using the Addressable gem, this PR avoids a Ruby deprecation warning about URI.unencode, without changing behavior.

This PR was created @chaymaeBZ and me, based on prior art by @bvicenzo.

  - This avoids a Ruby deprecation warning about URI.unencode, without
changing behavior
  - The code was inspired by previous work done by bvicenzo. Thanks!

Co-authored-by: Chaymae Bazzaoui <bazzaoui.chaymae@gmail.com>
Co-authored-by: Bruno Vicenzo <bvicenzo@users.noreply.github.com>
@olleolleolle olleolleolle merged commit 213d70a into savonrb:master Jul 15, 2020
@olleolleolle olleolleolle deleted the unescape-using-addressable branch July 15, 2020 18:14
bc-anthonycastiglione added a commit to bc-anthonycastiglione/wasabi that referenced this pull request Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant